Leverage npm scripts instead of requiring gulp to be installed globally. #280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There is no reason, it was coded that way initially, and Gulp was new at the time. We did not know any better :). This is cool I will check out the work. |
|
For my reference, uninstall gulp globally:
|
|
I tested it, seems to work. I am going to wait for a better moment to merge it into master but this is great, thanks! |
|
I merged this to master, thanks for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there! I was checking out Bedrock and it struck me that having gulp installed globally is required to get it to work. This PR removes that dependency and might make a little bit easier for people to get going with Bedrock. I've tested this locally on node 8.3 and it works, but maybe give it another spin to be sure! Feel free to decline if there's another reason for having gulp installed globally.
Cheers!
Jelle